[Gecko Bug 1626108] Adjust test expectations in flexbox WPT negative-overflow.html, to indicate that negative cross-axis overflow in a "wrap-reverse" flexbox should be scrollable. #28389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dicate that negative cross-axis overflow in a "wrap-reverse" flexbox should be scrollable. This testcase wasn't accounting for the fact that "flex-wrap: wrap-reverse" flips the direction in which overflow is reachable/scrollable, in a flex container's cross axis (just as "flex-direction: column-reverse" does in the main axis). The CSSWG resolved on this here: https://lists.w3.org/Archives/Public/www-style/2014Sep/0187.html This commit makes the test account for this, by increasing the expected scrollHeight of the "wrap-reverse" pieces of the test (which have overflow that should be scrollable). Note that Chromium doesn't pass these amended subtests, because it doesn't correctly handle scrolling with wrap-reverse; this is covered by https://bugs.chromium.org/p/chromium/issues/detail?id=1114306 . (However, if I modify the test to use "wrap" instead of "wrap-reverse", then Chromium does pass these subtests. This indicates that Chromium does essentially agree on the expected value here, aside from that bug report about making the overflow scrollable.) Differential Revision: https://phabricator.services.mozilla.com/D110968 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1626108 gecko-commit: 5574f84255953f4cbb1616e51fb9efa1f846c108 gecko-reviewers: TYLin
wpt-pr-bot
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This testcase wasn't accounting for the fact that "flex-wrap: wrap-reverse"
flips the direction in which overflow is reachable/scrollable, in a flex
container's cross axis (just as "flex-direction: column-reverse" does in the
main axis). The CSSWG resolved on this here:
https://lists.w3.org/Archives/Public/www-style/2014Sep/0187.html
This commit makes the test account for this, by increasing the expected
scrollHeight of the "wrap-reverse" pieces of the test (which have overflow that
should be scrollable).
Note that Chromium doesn't pass these amended subtests, because it doesn't
correctly handle scrolling with wrap-reverse; this is covered by
https://bugs.chromium.org/p/chromium/issues/detail?id=1114306 . (However, if I
modify the test to use "wrap" instead of "wrap-reverse", then Chromium does
pass these subtests. This indicates that Chromium does essentially agree on
the expected value here, aside from that bug report about making the overflow
scrollable.)
Differential Revision: https://phabricator.services.mozilla.com/D110968
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1626108
gecko-commit: 5574f84255953f4cbb1616e51fb9efa1f846c108
gecko-reviewers: TYLin