Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that document.open() removes initial about:blankness #28403

Merged
merged 2 commits into from Apr 14, 2021

Conversation

domenic
Copy link
Member

@domenic domenic commented Apr 7, 2021

Follows whatwg/html#6567.

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb comments in this test!

Co-authored-by: Philip Jägenstedt <philip@foolip.org>

// Create the Window object. It will be for the initial about:blank since the load of /common/blank.html hasn't
// completed.
document.body.append(iframe);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quibble about these comments, it'll only start loading/navigating right here, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the comment on lines 10-12 applies to both lines 13 and 17.

@domenic domenic merged commit d405c38 into master Apr 14, 2021
@domenic domenic deleted the remove-initial-about-blankness branch April 14, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants