Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move FileAPI/reading-data-section to any.js #28401

Merged

Conversation

lucacasonato
Copy link
Member

This PR intentionally does not touch indentation in the JS files to make the review diff less painful. Indentation can be changed in a follow-up PR.

Copy link
Contributor

@mkruisselbrink mkruisselbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea what's up with the lint failure:
FileAPI/reading-data-section/FileReader-multiple-reads.any.js:1: Metadata comments should start the line (INDENTED-METADATA)

Not sure why it thinks that line is indented... Otherwise this looks good to me.

@lucacasonato
Copy link
Member Author

@mkruisselbrink Fixed now - no idea what caused it. Deleted the original file and copied the contents into the new file again... very strange.

@Ms2ger Ms2ger merged commit 648205d into web-platform-tests:master Apr 21, 2021
@lucacasonato lucacasonato deleted the reading-data-section-any-js branch April 21, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants