[css-flex/tables] Stop flex from shrinking tables below their min height #28406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tables can't have height less than their intrinsic block size. Otherwise, cells would overflow the table, which breaks a table invariant. FlexNG was assigning tables heights that are too short. Legacy tables ignored FlexNG and assigned themselves a proper height, so we never noticed this bug. TablesNG was trying to obey flex's imposed height, which brought this FlexNG bug to light. Now FlexNG always assigns a block size greater than or equal to the table's intrinsic block size when it is laid out with whatever final inline size the flexbox gives (stretched or unstretched). There is no spec requiring this in the block direction, even though Firefox and legacy Blink both do it, and there is a spec requirement for the inline direction. So the tests are marked tentative. Bug: 1181403 Change-Id: I538188d2749d0c1e0a277068c59fbb26759b1756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2810520 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#870270}
wpt-pr-bot
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tables can't have height less than their intrinsic block size.
Otherwise, cells would overflow the table, which breaks a table
invariant.
FlexNG was assigning tables heights that are too short. Legacy tables
ignored FlexNG and assigned themselves a proper height, so we never
noticed this bug. TablesNG was trying to obey flex's imposed height,
which brought this FlexNG bug to light.
Now FlexNG always assigns a block size greater than or equal to the
table's intrinsic block size when it is laid out with whatever final
inline size the flexbox gives (stretched or unstretched).
There is no spec requiring this in the block direction, even though
Firefox and legacy Blink both do it, and there is a spec requirement for
the inline direction. So the tests are marked tentative.
Bug: 1181403
Change-Id: I538188d2749d0c1e0a277068c59fbb26759b1756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2810520
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#870270}