[SelectMenu] Allow <option> to render arbitrary content when it is a descendant of <selectmenu>. #28377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 5, 2021
…descendant of <selectmenu>. This CL enables the <option> element to render arbitrary content when it is a descendant of <selectmenu> by adding a default slot that gets all the <option>'s children. We may refine the content allowed under the <option> as some element types may not make sense[1]. [1]: http://crbug.com/1196022 Bug: 1121840, 1196022 Change-Id: I4200d4653e3d1fbebb082c351e0d2374cd1f7312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2806116 Reviewed-by: Dan Clark <daniec@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#869792}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2806116
branch
from
61a4ab4
to
5da16f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL enables the <option> element to render arbitrary content when it
is a descendant of <selectmenu> by adding a default slot that gets
all the <option>'s children.
We may refine the content allowed under the <option> as some element
types may not make sense1.
Bug: 1121840, 1196022
Change-Id: I4200d4653e3d1fbebb082c351e0d2374cd1f7312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2806116
Reviewed-by: Dan Clark <daniec@microsoft.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#869792}