Disasters: wrong location shown in factory/refinery destroyed message #8956

LC-Zorg · 2021-04-05T21:28:02Z

Version of OpenTTD

1.11.0

Expected result

The message shows the correct location of the incident

Actual result

The shown location of the incident is incorrect - it always shows the top left edge of the map.

Steps to reproduce

The bug always appears, just start the game with disasters.

2TallTyler · 2021-04-05T22:15:24Z

Sounds like #8810.

James103 · 2021-04-06T20:51:42Z

From some of my own testing (and looking at the code), it appears that the news message is likely using the industry's ID as the tile ID to display in the news message, and not the actual location of the (northernmost) corner of the industry itself. See the following code segments for a likely backtrace:

OpenTTD/src/disaster_vehicle.cpp

Line 459 in 825867f

AddTileNewsItem(news_message, NT_ACCIDENT, v->dest_tile);

OpenTTD/src/disaster_vehicle.cpp

Lines 471 to 472 in 825867f

    
           IndustryID ind = GetIndustryIndex(tile); 
        
           v->dest_tile = ind;

OpenTTD/src/industry_map.h

Lines 63 to 67 in 825867f

    
           static inline IndustryID GetIndustryIndex(TileIndex t) 
        
           { 
        
           	assert(IsTileType(t, MP_INDUSTRY)); 
        
           	return _m[t].m2; 
        
           }

OpenTTD/src/industry_map.h

Lines 278 to 282 in 825867f

    
           static inline void MakeIndustry(TileIndex t, IndustryID index, IndustryGfx gfx, uint8 random, WaterClass wc) 
        
           { 
        
           	SetTileType(t, MP_INDUSTRY); 
        
           	_m[t].m1 = 0; 
        
           	_m[t].m2 = index;

…ation

…cation

…cation (OpenTTD#8992)

…8992)

TrueBrain added the bug label Apr 10, 2021

LordAro closed this as completed in c506263 Apr 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disasters: wrong location shown in factory/refinery destroyed message #8956

Disasters: wrong location shown in factory/refinery destroyed message #8956

LC-Zorg commented Apr 5, 2021

2TallTyler commented Apr 5, 2021

James103 commented Apr 6, 2021

Disasters: wrong location shown in factory/refinery destroyed message #8956

Disasters: wrong location shown in factory/refinery destroyed message #8956

Comments

LC-Zorg commented Apr 5, 2021

Version of OpenTTD

Expected result

Actual result

Steps to reproduce

2TallTyler commented Apr 5, 2021

James103 commented Apr 6, 2021