Add: support of square root and round functions to builtin functions #199
Conversation
nml/expression/functioncall.py
Outdated
| raise generic.ScriptError("sqrt() requires 1 argument", pos) | ||
| elif len(args) != 1: | ||
| raise generic.ScriptError("sqrt() requires only 1 argument", pos) | ||
| return ConstantFloat(math.sqrt(args[0].value),pos) |
There was a problem hiding this comment.
This probably needs a check for args[0] being a constant value, similar as for the trigonometric functions above.
if not isinstance(val, (ConstantNumeric, ConstantFloat)):
raise generic.ScriptError("Parameter for " + name + "() must be a constant", pos)
Actually, it may be easier to just extend the mapping in builtin_trigonometric, and rename it to builtin_math or something.
There was a problem hiding this comment.
Updated Pull Request's commit with proposed updates
werbfred
changed the title
werbfred
changed the title
|
Added round builtin as well as it's better than using int. This way floats are rounds down/up to its nearest integer. In my use case, this allows using formulas to determine base/running costs more accurate and ensuring them to be an 1 Byte integer. |
|
You can simply add Please reorder or squash the commits so you're not introducing an error and then fixing it. That should also make the commit-checker stop complaining. |
|
Round should return a ConstantNumeric i.e. an integer value, while all other math functions as sqrt and existing sin, cos, tan return ConstantFloat s... |
Sorry, I missed that. My mistake. |
These require constant arguments and map to the Python functions.
Added sqrt function to builtin ones as it could be usefull in other projects.
I implemented it because the SQRT approximation in 2cc_TrainsInNML.grf was giving sometimes weird results. Using math.sqrt is much more accurate.