Revert "[css-flexbox] Margin collapsing bug in WebKit preventing some flexbox tests from succeeding (#28368)" #28379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flexbox tests from succeeding (web-platform-tests#28368)" This reverts commit 33f6a9c. All the other engines started to fail after adding the WebKit hack. What's more the hack was working fine for WebKitGtk+ but not for Safari for example. So I'll just revert it and focus on fixing the WebKit bug.
wpt-pr-bot
requested review from
cbiesinger,
fantasai,
kojiishi,
mrego,
plinss,
rachelandrew and
tabatkins
mrego
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 33f6a9c.
All the other engines started to fail after adding the WebKit hack. What's more the hack was working fine for WebKitGtk+ but not for Safari for example. So I'll just revert it and focus on fixing the WebKit bug.