Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: [CMake] Improve 'In-source build' error message #8955

Merged
merged 1 commit into from Apr 6, 2021
Merged

Change: [CMake] Improve 'In-source build' error message #8955

merged 1 commit into from Apr 6, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Apr 5, 2021

Motivation / Problem

Once you tried to run cmake from source dir, you will constantly get the In-source builds not allowed. Please run \"cmake ..\" from the bin directory message, even if you follow what it says.
That's because cmake created a CMakeCache.txt in source dir with "wrong" binary dir, and cmake will always use it.

Description

Add a hint to the error message to delete "broken" CMakeCache.txt

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

TrueBrain
TrueBrain reviewed Apr 5, 2021
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label Apr 5, 2021
@glx22 glx22 changed the title Change: [CMake] Improve In-source error message Change: [CMake] Improve 'In-source build' error message Apr 5, 2021
@glx22 glx22 merged commit 39b4a8e into OpenTTD:master Apr 6, 2021
@glx22 glx22 deleted the in_source branch April 6, 2021 11:54
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request Apr 17, 2021
@glx22 @LordAro
Change: [CMake] Improve 'In-source build' error message (OpenTTD#8955)
cddd672
LordAro pushed a commit that referenced this pull request Apr 18, 2021
@glx22 @LordAro
Change: [CMake] Improve 'In-source build' error message (#8955)
19b3f77
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain left review comments

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glx22 @TrueBrain @LordAro