Codechange: Suppress warnings when asserts are disabled #8916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
added
the
backport requested
TrueBrain
previously approved these changes
Mar 31, 2021
nielsmh
reviewed
Mar 31, 2021
Comment on lines
294
to
296
| #ifndef NDEBUG | ||
| SQInteger z = _table(_thread(_root_vm)->_roottable)->CountUsed(); | ||
| #endif | ||
| assert(z == x); |
There was a problem hiding this comment.
For readability I think it'd be better to wrap the assert into the #ifndef block too, even if it's the same effect.
LordAro
force-pushed
the
release-warnings
branch
from
5efe2c1
to
fdba4d7
Compare
TrueBrain
approved these changes
Apr 1, 2021
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Apr 1, 2021
TrueBrain
pushed a commit
that referenced
this pull request
Apr 1, 2021
TrueBrain
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Compiler warnings when compiling with asserts disabled (see #8914 output)
Description
Fixes warnings. Mostly just disabling the code. Only "major" change is surrounding the blitter registering
Limitations
None?
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.