Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object selection window button doesn't appear lowered after clicking on it #8939

Closed
perezdidac opened this issue Apr 3, 2021 · 3 comments
Closed

Object selection window button doesn't appear lowered after clicking on it #8939

perezdidac opened this issue Apr 3, 2021 · 3 comments
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! good first issue Good for newcomers

Comments

@perezdidac
Copy link
Contributor

Version of OpenTTD

1.11, but 1.10 as well and probably before that.

Expected result

The select object window button stays lowered until the object selection window is closed.

Actual result

The select object window button immediately raises after clicking on it.

Steps to reproduce

  1. Start a game with NewGRFs that include objects (i.e. Fridaemon objects)
  2. Open the terraform/landscape toolbar
  3. Click in the Object selection window (transmitter icon)
  4. Observe actual result and not expected result

Notes

I've done some work to trying to fix it but still not completely fixed.
@nielsmh
Copy link
Contributor

nielsmh commented Apr 4, 2021

Can't reproduce, the Select Object button raises after click for me in 1.11.0.

@perezdidac
Copy link
Contributor Author

Can't reproduce, the Select Object button raises after click for me in 1.11.0.

That is the problem, I expect it to stay lowered just like the rail station button for instance.

@TrueBrain TrueBrain added the needs triage This issue needs further investigation before it becomes actionable label Apr 10, 2021
@2TallTyler 2TallTyler added good first issue Good for newcomers enhancement Issue would be a good enhancement; we accept Pull Requests! and removed needs triage This issue needs further investigation before it becomes actionable labels Nov 14, 2022
@2TallTyler
Copy link
Member

I think this is intended behavior. The rail toolbar only allows one tool to be open at a time, so if you have the station tool open (with its button lowered) and then open the depot tool, the station tool closes and its button raises.

In the terraform toolbar (which includes the object button), clicking the Trees or Objects buttons causes that tool window to open. But those windows are not exclusive: other windows can be open at the same time. For this reason, it wouldn't make sense to keep either of these buttons lowered when that tool is open.

In my mind, this is an intentional behavior and not a bug nor an inconsistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nielsmh @TrueBrain @perezdidac @2TallTyler