Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frequent crashes when staging procedural fairings #2931

Closed
Amselfass opened this issue Mar 30, 2021 · 3 comments · Fixed by #2971
Closed

Frequent crashes when staging procedural fairings #2931

Amselfass opened this issue Mar 30, 2021 · 3 comments · Fixed by #2971
Labels
bug
Milestone
Green

Comments

@Amselfass
Copy link

Amselfass commented Mar 30, 2021 •
edited

Good afternoon,

I am experiencing Principia crashes when staging procedural fairings. These crashes are frequent (I would say about 20 % of my fairing separations result in a crash) but unfortunately not reproducible at will (i.e. I cannot identify a set of vessel properties or flight parameters that will always / never produce a crash).

The crash occurs on pressing spacebar when the next stage has a procedural fairing separation in it. It instantly crashes to desktop, with no Windows dialog boxes shown. The Unity Crash Handler does not show. There is no KSP crash log produced in %LocalAppData%/Temp/Squad/Kerbal Space Program/Crashes.

My KSP version is 1.10 and I am using Principia version Goldbach. However, I already experienced the same issue with KSP 1.8 and Principia Гельфонд.

Here are the .FATAL and .INFO files.

I have also produced a journal file (caution: 1 GB download!).

Please let me know if you require further information.
@sohmien
Copy link

sohmien commented Mar 30, 2021 •
edited

I also had such crashes, but didn't know it was caused by Principia. My solution was to disable fairing decouplers, so that the interstage decouples with fairings still attached. This way the game doesn't crash.
edit: btw, it only happens with interstage fairings. Payload fairings separate reliably without any crashes.

@pleroy pleroy added the bug label May 2, 2021
This was referenced May 2, 2021
Closed
Closed
@pleroy
Copy link
Member

pleroy commented May 2, 2021

I was able to replay the journal and reproduce the bug. No idea what's going on yet.

@pleroy pleroy mentioned this issue May 2, 2021
Merged
@pleroy pleroy added this to the Green milestone May 2, 2021
@pleroy
Copy link
Member

pleroy commented May 2, 2021

So this is a segue of #2507, with variations.

In #2507 we were trying to insert points before the beginning of the psychohistory when parts moved from one vessel to another. This could happen if the adaptive-step integrator would generate multiple points in a short period of time, e.g., because of high accelerations due to collisions.

In this issue we are trying to insert points before the beginning of the history. How can this happen, you ask, when the history is using a fixed-step integrator? Well, not always: when burning we directly copy the psychohistory to the history, and it is using an adaptive-step integrator. So if you have high collisions and are burning you may end up in this situation.

@Amselfass, thanks a lot for taking the time to send us a journal, it would have been impossible to debug without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Green
Development

Successfully merging a pull request may close this issue.

Only append the barycentre of the parts if it is after the end of the trajectory pleroy/Principia
3 participants
@pleroy @Amselfass @sohmien