Change: [CMake] Copy AI/GS compatibility files to build dir #8906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this simplify the installer targets at all? I've not looked, but they must be already copying the script files, is that still necessary? Also, does this want backporting? I'd assume so |
|
I don't understand the question about installer targets. |
michicc
approved these changes
Mar 31, 2021
LordAro
added
the
backport requested
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
Apr 17, 2021
LordAro
pushed a commit
that referenced
this pull request
Apr 18, 2021
LordAro
added
backported
glx22
added a commit
to glx22/OpenTTD
that referenced
this pull request
Apr 19, 2021
glx22
added a commit
to glx22/OpenTTD
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8618
Motivation / Problem
When running
openttdfrom build dir, Script API compatibility files are not found.And for MSVC project build it's worse as lang files are not found either 😉.
Description
compat_*.nutfiles are now copied to build dir when compiling.I also changed MSVC working dir to build dir (instead of bin).
Since build dir now contains the exact list of compat files, I decided to use them for install instead of bin dirs (which may contain extra stuff in an unclean checkout).
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.