Change: Explicitly specify SHA1 for legacy code signing on Windows #9684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Due to an upgrade of the Windows SDK used on the GitHub Actions virtual environments, an error is printing when attempting to code sign:
This means the certificate is only being SHA-256 timestamped, but the SHA-1 timestamping is failing. While this doesn't really matter for modern versions of Windows, Windows Vista and possibly 7 pre-SP1 only support SHA-1.
Description
This patch updates the syntax of the SignTool call to be explicit about the digest algorithm we want to use.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.