-
-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Don't show screenshot GUI in screenshots #9674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't blame JGR for the codestyle issues, you did those all by yourself ;) (In theory you should be able to add JGRPP repo as a remote and just cherry-pick it)
1a3a595
to
1435d14
Compare
Someday I'll learn not to stay up past my bedtime to submit PRs and miss silly things. 🙄 I prefer not to cherry-pick because going through the motions of adding the code myself helps me understand it and (when I'm paying attention) catch missing code style, Doxygen, or references to other code not present in vanilla. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is absolute nitpicking. But as you indicate you would like to learn from these PRs, here is some feedback. Despite this PR being a few lines, there are just some issues with the logic used :)
1435d14
to
3dc0dd4
Compare
Thank you for the educational nitpicking! 😄 Let me know what you think of these changes. |
3dc0dd4
to
1b79ade
Compare
1b79ade
to
2e05f17
Compare
Motivation / Problem
Screenshots captured using the "Normal screenshot" button show the screenshot GUI. The other screenshot modes do not.
I often see new players posting screenshots using this button on Discord, Reddit, etc., which is typically met with suggestions to use another screen capture tool which doesn't show the screenshot GUI.
I can imagine a player wanting to show other GUI elements like vehicle windows, the status bar ("look at how much money I have!"), and even the main toolbar at top. But I don't see a reason to show the screenshot GUI itself!
Description
Upstreams a JGRPP commit to hide the screenshot GUI when taking a screenshot.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.