Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the plugin compatibility test to DiscreteTraject0ry #3195

Merged
merged 4 commits into from
Nov 6, 2021
Merged

Convert the plugin compatibility test to DiscreteTraject0ry #3195

merged 4 commits into from
Nov 6, 2021
+23 −25

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Nov 6, 2021

@eggrobin eggrobin added the LGTM label Nov 6, 2021
eggrobin
eggrobin approved these changes Nov 6, 2021
View reviewed changes
ksp_plugin_test/plugin_compatibility_test.cpp Outdated
auto history = vessel.history();
auto psychohistory = vessel.psychohistory();
EXPECT_EQ(435'927, history->size());
EXPECT_EQ(3, psychohistory->size());
Copy link
Member

@eggrobin eggrobin Nov 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SizeIs.

Same below.

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sorry, something went wrong.

@pleroy pleroy merged commit 69fb0f9 into mockingbirdnest:Ondelette Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eggrobin eggrobin

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pleroy @eggrobin