New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Specify minimum version for macOS #9689
Conversation
Is 10.14 our actual minimum version, or just the minimum version of our builds? |
Let me try to build on my ancient Mac and find out... |
My ancient Mac isn't able to compile modern OpenTTD, even attempting various newer versions of gcc and clang from MacPorts. I don't have a system with 10.12 or 10.13 on, so couldn't tell you if either of those would work. I'd personally be inclined to accept the patch and if anybody complains, we can change it. Alternatively, I can change it so that it's only applied for the builds that we do if preferred. |
Patching the Plist during the CI build sounds a little more reasonable to me, if it's theoretically possible to still build with a toolchain that can target older macOS versions. |
We use We were under the impression our framework bump to 10.14 would already fix it, but clearly this is not the case. So yeah, this is the right solution :) I am not aware of any theoretical solution @nielsmh ; if you have anything on that I would love to know. But from our investigation a few months ago, this really is not solvable by any toolchain :( |
Motivation / Problem
OpenTTD will open on macOS versions earlier than 10.14, but will crash.
Fixes #9688.
Description
This adds a minimum version to the Info.plist so the Finder will not allow the application to launch. It will display a minimum version warning instead.
Limitations
Tested on macOS 10.11 on my ancient MacBook Pro; with this patch it was greyed out and displayed a warning, without the patch it opened and crashed.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.