Fix: Don't show screenshot GUI in screenshots #9674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
previously requested changes
Nov 6, 2021
LordAro
added
the
backport requested
2TallTyler
force-pushed
the
hide_screenshot_gui
branch
from
1a3a595
to
1435d14
Compare
|
Someday I'll learn not to stay up past my bedtime to submit PRs and miss silly things. 🙄 I prefer not to cherry-pick because going through the motions of adding the code myself helps me understand it and (when I'm paying attention) catch missing code style, Doxygen, or references to other code not present in vanilla. |
TrueBrain
reviewed
Nov 7, 2021
2TallTyler
force-pushed
the
hide_screenshot_gui
branch
from
1435d14
to
3dc0dd4
Compare
|
Thank you for the educational nitpicking! 😄 Let me know what you think of these changes. |
TrueBrain
reviewed
Nov 7, 2021
2TallTyler
force-pushed
the
hide_screenshot_gui
branch
from
3dc0dd4
to
1b79ade
Compare
TrueBrain
previously approved these changes
Nov 7, 2021
michicc
reviewed
Nov 7, 2021
2TallTyler
force-pushed
the
hide_screenshot_gui
branch
from
1b79ade
to
2e05f17
Compare
michicc
approved these changes
Nov 7, 2021
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Nov 7, 2021
TrueBrain
added
backported
TrueBrain
pushed a commit
that referenced
this pull request
Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Screenshots captured using the "Normal screenshot" button show the screenshot GUI. The other screenshot modes do not.
I often see new players posting screenshots using this button on Discord, Reddit, etc., which is typically met with suggestions to use another screen capture tool which doesn't show the screenshot GUI.
I can imagine a player wanting to show other GUI elements like vehicle windows, the status bar ("look at how much money I have!"), and even the main toolbar at top. But I don't see a reason to show the screenshot GUI itself!
Description
Upstreams a JGRPP commit to hide the screenshot GUI when taking a screenshot.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.