Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix f2cab72: Called procedures may receive wrong values in parameters #227

Merged
merged 1 commit into from Jul 27, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Jul 17, 2021

When temporary intermediate variables are used, register number was passed as call parameter instead of the register content.

It's quite obvious in NFO diffs (\2r 1A vs \2r 7D), but I totally missed it before.

@andythenorth
Copy link
Contributor

Fixes this FIRS test case as expected. https://gist.github.com/andythenorth/df51f3b8fa7bce212a87604702fb836c

@glx22 glx22 merged commit 8ed9791 into OpenTTD:master Jul 27, 2021
@glx22 glx22 deleted the temp_vars branch July 27, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants