Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts when cell name equals its cell type #52

Open
acomodi opened this issue Jul 16, 2021 · 1 comment
Open

Conflicts when cell name equals its cell type #52

acomodi opened this issue Jul 16, 2021 · 1 comment

Comments

@acomodi
Copy link
Contributor

acomodi commented Jul 16, 2021

In the process of testing a very basic LiteX design, I stumbled upon an issue for which, if a cell is given the name equal to the corresponding cell_type, than the cell would not be present in the physical netlist. E.g.:

PLLE2_ADV #( 
    <attrs>
) PLLE2_ADV (
    <ports>
);

The above does not end up in the output physical netlist.

I have tracked down the issue potentially being in the collision of cell name and cell type when checking whether to create a leaf cell or generate a submodules in nextpnr, and all the missing cells do indeed have the colliding name - type strings.

Unclear what the best solution is at the moment, but maybe we may address this when generating the logical netlist and, in case the cell name and cell type are equal, the cell name should be prefixed/suffixed with something to differentiate them.

@gatecat
Copy link
Contributor

gatecat commented Jul 27, 2021

Missed this issue, but hit this myself testing LiteX stuff (#54) and have fixed it in YosysHQ/nextpnr#779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants