Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: use GitHub composite actions over NPM-based for checkout* actions #30

Merged
merged 2 commits into from Jul 20, 2021
Merged

Change: use GitHub composite actions over NPM-based for checkout* actions #30

merged 2 commits into from Jul 20, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jul 20, 2021 •
edited

We are so sick and tired of how npm works .. updating is just ..
ugh. Also, it changes 50 lines of Typescript into 9500 lines of
Javascript, just to run some very simple basic commands.

So yeah .. where possible, let's switch to something more manageable.

@TrueBrain TrueBrain changed the title Change: use GitHub composite actions over NPM-based where possible Change: use GitHub composite actions over NPM-based for checkout* actions Jul 20, 2021
@TrueBrain
Change: use GitHub composite actions over NPM-based for checkout* act…
0747414 
…ions

We are so sick and tired of how npm works .. updating is just ..
ugh. Also, it "compiles" 50 lines of Typescript into 9500 lines of
Javascript, just to run some very simple basic commands.

So yeah .. where possible, let's switch to something more manageable.
@TrueBrain
Add: write test for checkout* actions
ebc55e7
LordAro
LordAro approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO.

Content seems to more or less match the originals

@TrueBrain TrueBrain merged commit 04d9906 into OpenTTD:main Jul 20, 2021
@TrueBrain TrueBrain deleted the use-composite branch July 20, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @LordAro