Fix 75b6051b: removing items from the ini could leave the group in a bad state #9445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
@LordAro had an ini-file that crashed the game upon save. Investigation showed I fucked up
IniGroup::RemoveItem
;)Description
There are a few things going on here, but mostly
last_item
is a shitty name for a pointer to the->next
of the real last item. I drew some wrong conclusions because of that, resulting in a broken implementation.Now when the last item of a group is removed,
last_item
points to thenext
of the previous value, keeping the group in a valid state.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.