Feature: reduce bandwidth needed to serve clients the serverlist #25
+198
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
force-pushed
the
gc-optimizations
branch
2 times, most recently
from
11469b2 to
2803c24
Compare
Game Coordinator protocol 4 allows us to send the client a table of NewGRFs, and after that use an index into that table for each server. This heavily reduces the size of the full serverlist, from ~60KB to ~20KB. Additionally, we now also send the name of the NewGRF to the client. In case the client doesn't have the NewGRF yet, it can now show the name of the NewGRF instead of the grfid or md5sum. Further more, this reduces the load on redis, as we only update NewGRFs when there is something to update, instead of every 30 seconds. NewGRFs in multiplayer games can only change when starting a newgame, and never during a game.
TrueBrain
force-pushed
the
gc-optimizations
branch
from
2803c24 to
2cec221
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Game Coordinator protocol 4 allows us to send the client a table
of NewGRFs, and after that use an index into that table for each
server. This heavily reduces the size of the full serverlist, from
~60KB to ~20KB.
Additionally, we now also send the name of the NewGRF to the client.
In case the client doesn't have the NewGRF yet, it can now show
the name of the NewGRF instead of the grfid or md5sum.
Further more, this reduces the load on redis, as we only update
NewGRFs when there is something to update, instead of every 30
seconds. NewGRFs in multiplayer games can only change when starting
a newgame, and never during a game.