Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suitesparse: 5.7.2 -> 5.8.1 #98485

Merged
merged 2 commits into from Dec 5, 2020
Merged

suitesparse: 5.7.2 -> 5.8.1 #98485

merged 2 commits into from Dec 5, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Sep 22, 2020 •
edited

Assert that compatible lapack and blas implementations are used. Update dependencies. Remove now not needed BLAS and LAPACK makeFlags.

Motivation for this change
Things done

Tested that Octave and Sundials build with this version, in a dirty branch, not with nixpkgs-review.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ttuegel September 22, 2020 18:29
@danieldk
Copy link
Contributor

danieldk commented Oct 1, 2020

This diff looks good to me, but it would be nice if the commit could be split. I assume that the gmp/mpfr dependencies and gnum4 removal come with the update. But it would be nice to put the BLAS-related changes in a separate commit to make it easier to inspect the history in the future.

Also, I am not very familiar with this derivation and it has a lot of reverse-dependencies, so it's probably better if @jtojnar or @ttuegel reviewed this PR.

@doronbehar
suitesparse: 5.7.2 -> 5.8.1
b34ca89 
Update dependencies. Remove not needed `BLAS` and `LAPACK` makeFlags for
non darwin systems.
@doronbehar
suitesparse: assert that compatible lapack and blas are used
6bbfd17
@doronbehar
Copy link
Contributor Author

But it would be nice to put the BLAS-related changes in a separate commit to make it easier to inspect the history in the future.

Done.

it has a lot of reverse-dependencies

I tested octave to build and run with this update, along with other related PRs merged (#98499 #98500 & #98501). I didn't test suitesparse related functionality though.

@doronbehar doronbehar mentioned this pull request Dec 4, 2020
Closed
@ttuegel ttuegel merged commit 4a5e1fb into NixOS:master Dec 5, 2020
@ttuegel
Copy link
Member

ttuegel commented Dec 5, 2020

Thanks! 😃

@doronbehar doronbehar deleted the pkg/suitesparse branch March 2, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@ttuegel ttuegel ttuegel approved these changes

@danieldk danieldk Awaiting requested review from danieldk

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doronbehar @danieldk @ttuegel @jtojnar