hicolor-icon-theme: fix quoting shell variables in setup hook #98426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
jtojnar
reviewed
Sep 27, 2020
| IFS=',' read -ra parent_themes <<< "$inheritance" | ||
| for parent_theme in "${parent_themes[@]}"; do | ||
| parent_path="" | ||
| if [ -e "$out/share/icons/$parent_theme" ]; then | ||
| parent_path="$(realpath $out/share/icons/$parent_theme)" | ||
| parent_path=$(realpath $out/share/icons/"$parent_theme") |
There was a problem hiding this comment.
There might be cases where where the parent_path will break (IIRC, if the variable contains a new line), so if we want to be shellcheck precise we probably need something like this:
Suggested change
| parent_path=$(realpath $out/share/icons/"$parent_theme") | |
| parent_path="$(realpath "$out/share/icons/$parent_theme")" |
jtojnar
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Without quoting the hook fails with themes with spaces in the name.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)