Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puppy: init at 0.0.7 #98428

Closed
wants to merge 1 commit into from
Closed

puppy: init at 0.0.7 #98428

wants to merge 1 commit into from

Conversation

9999years
Copy link
Contributor

Adds @eiais' puppy program to nixpkgs.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) N/A
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

eiais
eiais approved these changes Sep 22, 2020
View reviewed changes
Copy link

@eiais eiais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for upstreaming this!

@9999years
Copy link
Contributor Author

Mind merging?

@neonfuz
Copy link
Contributor

neonfuz commented Oct 5, 2020

Not to be discouraging, but upstream doesn't even have a readme. What does this program do? Why would somebody want this program? The only documentation I see is your description string saying it's like fortune. Linux distros need some quality control, they can't accept every little program in existence. I'm not a nixpkgs maintainer so I can't merge or choose not to, but I suggest at least adding a readme to upstream so people can know why they would want this package.

@SuperSandro2000
Copy link
Member

Upstream project got deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiais eiais eiais approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@9999years @neonfuz @SuperSandro2000 @eiais