Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add patch to goaccess so it will build on darwin #98431

Closed
wants to merge 1 commit into from
Closed

Add patch to goaccess so it will build on darwin #98431

wants to merge 1 commit into from

Conversation

CorbanR
Copy link
Contributor

@CorbanR CorbanR commented Sep 21, 2020

Motivation for this change

Fix build on OSX

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • [x ] macOS
    • [ x] other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [x ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 21, 2020
@ofborg ofborg bot requested a review from ederoyd46 September 21, 2020 23:50
@CorbanR CorbanR changed the title Add patch to goaccess to it will build on darwin Add patch to goaccess so it will build on darwin Sep 22, 2020
@CorbanR
Copy link
Contributor Author

CorbanR commented Nov 20, 2020

looks like this was fixed with #101709

@CorbanR CorbanR closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ederoyd46 ederoyd46 ederoyd46 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CorbanR @ederoyd46