Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing myself from maintainers lists of blockchains #98445

Merged
merged 1 commit into from Sep 22, 2020
Merged

Removing myself from maintainers lists of blockchains #98445

merged 1 commit into from Sep 22, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Sep 22, 2020 •
edited

Motivation for this change

Well, I am no longer interested in maintain these expressions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AndersonTorres AndersonTorres changed the title Removing myself from maintainers list of blockchains Removing myself from maintainers lists of blockchains Sep 22, 2020
@mmahut mmahut merged commit 06b2789 into NixOS:master Sep 22, 2020
@AndersonTorres AndersonTorres deleted the goodbye-blockchains branch September 22, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndersonTorres @mmahut