[LayoutNG] Multicol baseline propagation support. #25662
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://drafts.csswg.org/css-align/#baseline-export
The "first baseline set" of a multicol container is the baseline of the
first line box in the first column (i,e, ignore all other columns), or
the baseline of the first line box in the first column spanner that has
such a thing, whichever comes first.
Multicol containers have no "last baseline set", and, as such,
fast/multicol/inline-block-baseline.html is invalid, since an
inline-block aligns with the "last baseline set". Remove the test, and
replace it with its antithesis, baseline-008.html in
wpt/css/css-multicol/.
And added a bunch of tests, since this feature seemed to have no
coverage, apart from the deleted test in fast/multicol/.
Bug: 829028
Change-Id: I954de9618fde87dbfa37292786ca6a2dcce9fa1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421462
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810140}