Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Multicol baseline propagation support. #25662

Merged
merged 2 commits into from Sep 25, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 21, 2020

Spec: https://drafts.csswg.org/css-align/#baseline-export

The "first baseline set" of a multicol container is the baseline of the
first line box in the first column (i,e, ignore all other columns), or
the baseline of the first line box in the first column spanner that has
such a thing, whichever comes first.

Multicol containers have no "last baseline set", and, as such,
fast/multicol/inline-block-baseline.html is invalid, since an
inline-block aligns with the "last baseline set". Remove the test, and
replace it with its antithesis, baseline-008.html in
wpt/css/css-multicol/.

And added a bunch of tests, since this feature seemed to have no
coverage, apart from the deleted test in fast/multicol/.

Bug: 829028
Change-Id: I954de9618fde87dbfa37292786ca6a2dcce9fa1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421462
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810140}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Spec: https://drafts.csswg.org/css-align/#baseline-export

The "first baseline set" of a multicol container is the baseline of the
first line box in the first column (i,e, ignore all other columns), or
the baseline of the first line box in the first column spanner that has
such a thing, whichever comes first.

Multicol containers have no "last baseline set", and, as such,
fast/multicol/inline-block-baseline.html is invalid, since an
inline-block aligns with the "last baseline set". Remove the test, and
replace it with its antithesis, baseline-008.html in
wpt/css/css-multicol/.

And added a bunch of tests, since this feature seemed to have no
coverage, apart from the deleted test in fast/multicol/.

Bug: 829028
Change-Id: I954de9618fde87dbfa37292786ca6a2dcce9fa1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421462
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810140}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e792835 into master Sep 25, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2421462 branch September 25, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants