Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages: unbreak #98461

Merged
merged 1 commit into from Sep 22, 2020
Merged

haskellPackages: unbreak #98461

merged 1 commit into from Sep 22, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 22, 2020

Motivation for this change

The packages build:

  • bustle
  • llvm-hs
  • llvm-hs-pretty
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

Looks good, thanks for fixing these up!

@cdepillabout cdepillabout merged commit 6c59fb7 into NixOS:haskell-updates Sep 22, 2020
@jtojnar jtojnar deleted the unbreak-llvm branch September 22, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @cdepillabout