Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waybar: Enable pulseaudio by default #98490

Merged
merged 1 commit into from Oct 3, 2020
Merged

waybar: Enable pulseaudio by default #98490

merged 1 commit into from Oct 3, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Sep 22, 2020

Motivation for this change

The default configuration use the pulseaudio module, but it fails to
load with errors since we've built the package without pulseaudio
support. Most systems already have pulseaudio in the system closure
anyways so the closure size change won't be noticable on end user systems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Synthetica9 September 22, 2020 20:09
@etu
waybar: Enable pulseaudio by default
37e47b7 
The default configuration use the pulseaudio module, but it fails to
load with errors since we've built the package without pulseaudio
support. Most systems already have pulseaudio in the system closure
anyways so the closure size change won't be noticable on end user systems.
@gebner
Copy link
Member

gebner commented Oct 3, 2020

Yes, this has also bugged me. I don't like using these config.pulseaudio flags in packages at all, they just cause recompilation.

@gebner gebner merged commit cfc9214 into NixOS:master Oct 3, 2020
@etu etu deleted the waybar-enable-pa branch October 3, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianFranzen FlorianFranzen Awaiting requested review from FlorianFranzen

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @gebner