Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inkscape: add inkcut extension #98491

Merged

Conversation

raboof
Copy link
Member

@raboof raboof commented Sep 22, 2020

Motivation for this change

So you can install inkscape complete with the inkcut extension from a single derivation. The derivation would look something like this:

{ pkgs ? import <nixpkgs> {} }:

pkgs.mkShell {
  buildInputs = [
    (pkgs.inkscape-with-extensions.override {
      inkscapeExtensions = [
        pkgs.inkscape-extensions.inkcut
      ];
    })
  ];
}
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof
Copy link
Member Author

raboof commented Oct 1, 2020

/marvin opt-in
/state needs_review

@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 1, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 1, 2020
@raboof raboof force-pushed the inkscape-add-inkcut-extension-on-top-of-master branch 2 times, most recently from 818a5c0 to 0ffa7be Compare October 1, 2020 11:50
@raboof
Copy link
Member Author

raboof commented Oct 22, 2020

/status needs_reviewer

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/373

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 19, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@raboof
Copy link
Member Author

raboof commented Nov 19, 2020

/status needs_reviewer

@raboof raboof force-pushed the inkscape-add-inkcut-extension-on-top-of-master branch from 0ffa7be to b3e20cb Compare November 22, 2020 10:03
@raboof raboof marked this pull request as ready for review November 22, 2020 10:14
@raboof raboof requested a review from FRidh as a code owner November 22, 2020 10:14
@raboof raboof requested a review from timokau November 22, 2020 10:14
@raboof raboof force-pushed the inkscape-add-inkcut-extension-on-top-of-master branch 2 times, most recently from 98deb01 to a23d5a9 Compare November 24, 2020 14:55
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly done, just found a debugging leftover.

pkgs/applications/misc/inkcut/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/inkscape/extensions.nix Outdated Show resolved Hide resolved
@raboof raboof force-pushed the inkscape-add-inkcut-extension-on-top-of-master branch from a23d5a9 to 297d1d6 Compare November 24, 2020 18:38
@raboof raboof requested a review from timokau November 24, 2020 18:44
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@timokau timokau merged commit 6f0c009 into NixOS:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants