Dino: Enable on macOS/Darwin #98418
Merged
Dino: Enable on macOS/Darwin #98418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove direct dependencies on some X11 libs. We still inherit them through Gtk+ but it's a start * Rename plugin files from .dylib to .so so Dino's plugin loader finds them The experience is still somewhat janky (no app icon, macOS thinks the app is called ".dino-wrapped", and the Cocoa menu bar is nonresponsive), but beyond this things mostly work fine
ofborg
bot
added
6.topic: darwin
vbgl
reviewed
Sep 21, 2020
pkgs/applications/networking/instant-messengers/dino/default.nix
Outdated
Show resolved
Hide resolved
Co-authored-by: Vincent Laporte <vbgl@users.noreply.github.com>
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
|
Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
Gtk+ but it's a start
The experience is still somewhat janky (no app icon, macOS thinks the app is called
".dino-wrapped", and the Cocoa menu bar is nonresponsive), but beyond this things
mostly work fine
sandboxinnix.confon non-NixOS linux)Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)N/ATested compilation of all pkgs that depend on this change usingN/A Package has no rdependsnix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)