neo4j: 3.5.14 -> 4.1.1 #98443
Closed
neo4j: 3.5.14 -> 4.1.1 #98443
+38
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, the upgrade from 3.5 to 4 looks none trivial. Not sure how we should handle this scenario https://neo4j.com/docs/operations-manual/current/upgrade/planning/ |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Still relevant. Having an up-to-date neo4j version (4.X) would be good. |
stale
bot
removed
the
2.status: stale
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/where-to-put-a-packages-variable-data/14391/3 |
| ''; | ||
|
|
||
| passthru.tests.nixos = nixosTests.neo4j; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "A highly scalable, robust (fully ACID) native graph database"; | ||
| homepage = "http://www.neo4j.org/"; |
There was a problem hiding this comment.
Suggested change
| homepage = "http://www.neo4j.org/"; | |
| homepage = "https://neo4j.com/"; |
11 tasks
|
I'd like to continue this in #136300. @jonringer are you okay if I close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
wanted to use it for an upcoming project. Had difficulty using the 3.5 version, so i bumped it, and redid some of the module
I'm not a big fan of how the state directory is created, but I'm not very knowledgeable with systemd.
The nixosTests also seem to have a high degree of failure with "no space left on device". Not sure if it's hitting RAM or space issues. Most likely RAM issues.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)