Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make webdriver client handle headers case insensitively #25680

Merged
merged 1 commit into from Sep 30, 2020
Merged

Make webdriver client handle headers case insensitively #25680

merged 1 commit into from Sep 30, 2020

Conversation

stephenmcgruer
Copy link
Contributor

Closes #25039

@stephenmcgruer stephenmcgruer mentioned this pull request Sep 22, 2020
Closed
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-25680 September 22, 2020 17:38 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-25680 September 22, 2020 17:55 Inactive
Hexcles
Hexcles approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a nit

Hopefully tests will continue to work...

tools/webdriver/webdriver/transport.py Outdated Show resolved Hide resolved
@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Sep 23, 2020 •
edited

Hopefully tests will continue to work...

I will be definitely doing trigger runs of everything that uses this client library before merging this. But only once we're happy with the code :)

@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-25680 September 23, 2020 12:06 Inactive
Hexcles
Hexcles reviewed Sep 23, 2020
View reviewed changes
tools/webdriver/webdriver/transport.py Show resolved Hide resolved
tools/webdriver/webdriver/transport.py Outdated Show resolved Hide resolved
tools/webdriver/webdriver/transport.py Outdated Show resolved Hide resolved
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-25680 September 23, 2020 15:45 Inactive
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-25680 September 23, 2020 15:54 Inactive
@stephenmcgruer @Hexcles
[WIP] Make webdriver client handle headers case insensitively
c992c00 
Closes #25039

Co-authored-by: Robert Ma <robertma@chromium.org>
@stephenmcgruer
Copy link
Contributor Author

Ok, I've rebased this and triggered a Chrome Dev run to start with.

@stephenmcgruer stephenmcgruer marked this pull request as ready for review September 29, 2020 13:02
@stephenmcgruer
Copy link
Contributor Author

So I forgot I hadn't landed this 😆 .

The stability checks timed out (unsurprising), the Firefox and Safari wpt.fyi results are the known flaky webdriver tests, Chrome wpt.fyi results look good.

The Chrome Dev diff is https://wpt.fyi/results/?diff&filter=ADC&run_id=700170006&run_id=681230006, I'm digging into it now.

cc @ziransun as an FYI.

@stephenmcgruer
Copy link
Contributor Author

The Chrome Dev diff is https://wpt.fyi/results/?diff&filter=ADC&run_id=700170006&run_id=681230006, I'm digging into it now.

This looks good; all the diffs appear to be tests that are already flaky.

I'll give this change 24 hours to give a chance for folks to raise concerns, then will merge based on LGTM from @Hexcles

@stephenmcgruer stephenmcgruer merged commit 9da95c4 into master Sep 30, 2020
@stephenmcgruer stephenmcgruer deleted the smcgruer/webdriver_py3 branch September 30, 2020 14:58
@stephenmcgruer stephenmcgruer changed the title [WIP] Make webdriver client handle headers case insensitively Make webdriver client handle headers case insensitively Sep 30, 2020
ziransun pushed a commit to ziransun/wpt that referenced this pull request Oct 6, 2020
@stephenmcgruer @Hexcles @ziransun
[WIP] Make webdriver client handle headers case insensitively (web-pl…
6146ad2 
…atform-tests#25680)

Closes web-platform-tests#25039

Co-authored-by: Robert Ma <robertma@chromium.org>

Co-authored-by: Robert Ma <robertma@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hexcles Hexcles Hexcles approved these changes

@andreastt andreastt Awaiting requested review from andreastt

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@jgraham jgraham Awaiting requested review from jgraham

@LukeZielinski LukeZielinski Awaiting requested review from LukeZielinski

@mjzffr mjzffr Awaiting requested review from mjzffr

@shs96c shs96c Awaiting requested review from shs96c

@whimboo whimboo Awaiting requested review from whimboo

Assignees

@Hexcles Hexcles

Labels
infra webdriver wg-testing_browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephenmcgruer @Hexcles @wpt-pr-bot