megapixels: init at 0.14.0 #98479
megapixels: init at 0.14.0 #98479
Conversation
OPNA2608
force-pushed
the
package-megapixels
branch
from
2f5a214
to
302d72c
Compare
|
Bumped to 0.9.0. More buttons have been added, one of them for opening the last taken image and the photo directory in their default applications. This silently fails on my phone. Will look into it more when I got NixOS on it. The code in question looks e.g. like this: sprintf(uri, "file://%s", last_path); /* path to a JPEG file */
if(!g_app_info_launch_default_for_uri(uri, NULL, &error)){
g_printerr("Could not launch image viewer: %s\n", error->message);
} |
OPNA2608
force-pushed
the
package-megapixels
branch
from
302d72c
to
f645a65
Compare
|
Bumped to 0.10.2. Added optional dependencies on libraw and imagemagick for converting the taken photos to tiff and jpg. |
|
LGTM I'll try and test it on my pinephone later, but it ran successfully. Thanks for packaging this! Result of 1 package built:
|
|
0.11.1 has been released in the meantime, and releases have slowed down abit. It adds very nice-to-have post-processing. I can do the bump itself without the extra deps, but I'd like to package them first. Waiting for halide: 2019.08.27 -> 10.0.0, enable on aarch64-linux so I can open a PR for HDR+. |
|
If you address the one review commit I am going to merge it and we can do the bump later. Feel free to ping me or write me on IRC about it. |
|
Result of 1 package built:
|
OPNA2608
force-pushed
the
package-megapixels
branch
from
f645a65
to
95b562f
Compare
|
@SuperSandro2000 I've bump it to the latest release without the hdr-plus dependency & tested build on x86_64-linux (doesn't run properly, not its intended environment). Building on my phone takes too long for me right now, but the only difference to what I'm using there is the optional hdr-plus dependency so I assume it'd run, just with worse image quality. |
|
Would be helpful to get this packaged! |
|
Result of 1 package built:
|
|
I'll bump it to 0.13.2, just building it for my phone to test it really quickly. |
OPNA2608
force-pushed
the
package-megapixels
branch
from
95b562f
to
f0a535f
Compare
|
Result of 1 package built:
|
OPNA2608
force-pushed
the
package-megapixels
branch
from
f0a535f
to
4d20d10
Compare
OPNA2608
force-pushed
the
package-megapixels
branch
from
4d20d10
to
1ae6b4c
Compare
|
Result of 1 package built:
|
|
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package built:
|
Motivation for this change
Packaging a well-behaving camera app that can use both of the PinePhone's cameras without any kernel hacks.
(Big) photo of the working app
Unsure where to put the package. It queries
/proc/device-tree/compatibleto figure out the device & available camera hardware, but configuration files in various locations may be used to override the detection - is that tooos-specific? I don't know what else is can run on. Wouldpkgs/applications/videobe better? Support for other devices may follow in the future, the shipped configuration files only describe the various PinePhone models right now.Reviewers with a PinePhone running NixOS would be highly appreciated if possible! I tested this on the pre-installed postmarketOS distro of my Community Edition 3GB model. Compiles on my desktop, but no configuration to describe a usable camera here so it won't exactly do much.
I'm considering writing a NixOS module to configure
/etc/megapixels.iniin case the user would like to override the camera settings on a system-level, would that make sense?cc @samueldr for mobile-nixos, @TilCreator for recently having worked on better PinePhone support
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)