Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv: install mpv_identify.sh #98467

Merged
merged 1 commit into from Sep 22, 2020
Merged

mpv: install mpv_identify.sh #98467

merged 1 commit into from Sep 22, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Sep 22, 2020

Motivation for this change

It is a file identification script.
It is used in mc default actions for video files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It is file identification script.
It is used in mc default actions for video files.
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and ofborg still builds it, of course :)

@doronbehar
Copy link
Contributor

Also script seems functional.

@doronbehar doronbehar merged commit 807654c into NixOS:master Sep 22, 2020
@romildo romildo deleted the upd.mpv branch September 22, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants