Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree sitter update #98465

Merged
merged 3 commits into from Sep 28, 2020
Merged

Tree sitter update #98465

merged 3 commits into from Sep 28, 2020

Conversation

teto
Copy link
Member

@teto teto commented Sep 22, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Profpatsch September 22, 2020 13:18
@teto
tree-sitter.grammars: compile scanner.cc if exists
be48328 
otherwise neovim's treesitter fails with for instance:
`undefined symbol: tree_sitter_bash_external_scanner_create`
@teto
Copy link
Member Author

teto commented Sep 23, 2020

cc @Profpatsch . Not sure if you are a neovim user but the Pr allows the grammar to be used with neovim (scanner.cc needs to be compiled for some parsers).

@teto
Copy link
Member Author

teto commented Sep 28, 2020

I've had no issues thus far, merging.

@teto teto merged commit 514bda6 into NixOS:master Sep 28, 2020
@teto teto deleted the tree-sitter branch September 28, 2020 11:30
@Profpatsch
Copy link
Member

Looks good to me. The comment above should go into the source code, other than that it’s fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @Profpatsch