Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests.haskell-shellFor: get compiling again #98459

Merged
merged 1 commit into from Sep 23, 2020
Merged

tests.haskell-shellFor: get compiling again #98459

merged 1 commit into from Sep 23, 2020

Conversation

cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Sep 22, 2020 •
edited

Motivation for this change

Get the haskell-shellFor test working again.

Here's an example of running the test:

$ nix-build -A tests.haskell-shellFor
/nix/store/7plqnaa0y9y1lfxvd17mclrcnkss7qgi-ghc-shell-for-packages-0

The haskell-shellFor test originally used the constraints-extras package, but that doesn't seem to be compiling anymore, so I changed it to just use constraints instead.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build tests.haskell-shellFor

@cdepillabout
Copy link
Member Author

This appears to be the last Haskell-related failure in ZHF #97479!

@cdepillabout
Copy link
Member Author

Works on x86_64-linux at least, so going ahead and merging in.

@cdepillabout cdepillabout merged commit 0ee3e5b into NixOS:haskell-updates Sep 23, 2020
@cdepillabout cdepillabout deleted the fix-haskell-shell-test branch September 23, 2020 03:39
@cdepillabout cdepillabout mentioned this pull request Sep 23, 2020
Merged
10 tasks
@cdepillabout cdepillabout mentioned this pull request Oct 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cdepillabout