Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmwareLinuxNonFree: 2020-05-19 -> 2020-09-18 #98420

Merged
merged 1 commit into from Oct 1, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

I noticed this was out of date and I needed some of the newer firmwares.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@TredwellGit
Copy link
Member

#94133 should be closed in favor of this.

Copy link
Member

@TredwellGit TredwellGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sha256 and outputHash need to be updated.

@lovesegfault
Copy link
Member Author

@TredwellGit Updated, not sure how I missed that :D

Copy link
Member

@TredwellGit TredwellGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpletz Please merge.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Fits CONTRIBUTING.md.

@TredwellGit
Copy link
Member

@NeQuissimus, the maintainer of this package does not appear to be active. Since you update the Linux package, could you please consider merging this or point me towards the right person.

@ajs124
Copy link
Member

ajs124 commented Oct 1, 2020

sha256 and outputHash need to be updated.

Why is this a fixed output derivation in the first place? Does the build process need network access?

@TredwellGit
Copy link
Member

See: #44605

@NeQuissimus NeQuissimus merged commit 5c18896 into NixOS:master Oct 1, 2020
@lovesegfault lovesegfault deleted the linux-firmware-bump branch October 1, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants