Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t.py: init at 2020-04-11 #98474

Closed
wants to merge 2 commits into from
Closed

t.py: init at 2020-04-11 #98474

wants to merge 2 commits into from

Conversation

illiusdope
Copy link
Contributor

Motivation for this change

It's a nice, simple todo tool. It's called t upstream, but since there's already a t in nixpkgs I've called it t.py.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

sternenseemann
sternenseemann requested changes Sep 22, 2020
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm. You can also probably use pname = "t"; attribute name and package name don't always match in nixpkgs.

pkgs/applications/misc/t_py/default.nix Outdated

python3Packages.buildPythonApplication {
pname = "t.py";
version = "2020-04-11";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "2020-04-11";
version = "unstable-2020-04-11";

sternenseemann
sternenseemann requested changes Sep 22, 2020
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pass buildPythonApplication from python3Packages instead of the whole package set. This doesn't make a huge difference, but is more in line with other python applications in top level nixpkgs.

pkgs/top-level/all-packages.nix Outdated
@@ -7307,6 +7307,8 @@ in

t = callPackage ../tools/misc/t { };

t_py = callPackage ../applications/misc/t_py { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
t_py = callPackage ../applications/misc/t_py { };
t_py = python3Packages.callPackage ../applications/misc/t_py { };

pkgs/applications/misc/t_py/default.nix Outdated
@@ -0,0 +1,20 @@
{ lib, python3Packages, fetchFromGitHub }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ lib, python3Packages, fetchFromGitHub }:
{ lib, buildPythonApplication, fetchFromGitHub }:

pkgs/applications/misc/t_py/default.nix Outdated
@@ -0,0 +1,20 @@
{ lib, python3Packages, fetchFromGitHub }:

python3Packages.buildPythonApplication {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python3Packages.buildPythonApplication {
buildPythonApplication {

@sternenseemann
Copy link
Member

Result of nixpkgs-review pr 98474 1

1 package built:
- t_py

@sternenseemann
Copy link
Member

t seems to have tests. I'm not exactly sure how to run them, maybe you can find that out and add a checkPhase.

@sternenseemann
Copy link
Member

Seems like steve is using cram: https://github.com/brodie/cram

@illiusdope
Copy link
Contributor Author

I initially didn't bother with the tests because I didn't know what I was looking at, but that was super easy 🤷

@sternenseemann
Copy link
Member

@GrahamcOfBorg build t_py

@sternenseemann
Copy link
Member

Last (hopefully) order of business would be squashing all the commits into a single t_py: init at 2020-04-11, I guess :)

@sternenseemann
Copy link
Member

Please rebase against master instead of using git merge to avoid unecessary merge commits when this PR is merged.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 28, 2020 00:18
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@Artturin
Copy link
Member

Artturin commented Feb 2, 2023

Reopen and rebase if you're still interested in this.

@Artturin Artturin closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@illiusdope @sternenseemann @Artturin @ryantm