Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read_xdc command accepts unknown commands #39

Open
tmichalak opened this issue Sep 22, 2020 · 2 comments
Open

read_xdc command accepts unknown commands #39

tmichalak opened this issue Sep 22, 2020 · 2 comments

Comments

@tmichalak
Copy link
Collaborator

Currently if the file that is read with the read_xdc command contains an unknown command no error is reported.
This is caused by the fact that read_xdc makes use of the unknown args procedure and implements the handler which returns the string of the called command surrounded by square bracket.
We need to make sure commands that are not number will error out.
@litghost
Copy link
Contributor

We need to make sure commands that are not number will error out.

Also if a number if supplied with more arguments.

So examples:

[0] -> [0]
[0 1] -> error
[get_ports 0] -> error
[get_ports] -> error

@litghost
Copy link
Contributor

Also we discussed having an option on read_xdc to control whether the behavior is a warning or an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@litghost @tmichalak