Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.{pure-python-adb,adb-shell,androidtv}: init #98452

Merged
merged 4 commits into from Oct 3, 2020
Merged

pythonPackages.{pure-python-adb,adb-shell,androidtv}: init #98452

merged 4 commits into from Oct 3, 2020

Conversation

JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Sep 22, 2020 •
edited

Motivation for this change

Support androidtv in Home Assistant

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mweinelt
mweinelt requested changes Sep 22, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off to a good start, but does not look complete yet.

pkgs/development/python-modules/adb-shell/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/adb-shell/default.nix Show resolved Hide resolved
pkgs/servers/home-assistant/component-packages.nix Outdated Show resolved Hide resolved
@JamieMagee JamieMagee force-pushed the adb-shell branch 2 times, most recently from 8a93af6 to 9756320 Compare September 23, 2020 12:50
@mweinelt
Copy link
Member

We're still missing androidtv and pure-python-adb. The rest looks good.

@JamieMagee
Copy link
Member Author

We're still missing androidtv and pure-python-adb. The rest looks good.

I was planning on opening separate PRs for those. Is that okay?

@mweinelt
Copy link
Member

Just include them here please, so we can have one pr including the component package regeneration.

@JamieMagee JamieMagee changed the title pythonPackages.adb-shell: init at 0.2.2 pythonPackages.{pure-python-adb,adb-shell,androidtv}: init Sep 24, 2020
@JamieMagee
Copy link
Member Author

JamieMagee commented Sep 24, 2020 •
edited

I've added all the required packages.

I'll make the changes to home-assistant in a followup PR. Home assistant needs a version bump anyway as 0.115.x has been released.

@JamieMagee JamieMagee force-pushed the adb-shell branch 2 times, most recently from 62485a5 to 1b13a04 Compare September 24, 2020 11:16
mweinelt
mweinelt requested changes Sep 24, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The packages look pretty good, please disable adb-shell on py27 and regenerate the component packages for home-assistant.

pkgs/development/python-modules/adb-shell/default.nix Show resolved Hide resolved
@mweinelt
Copy link
Member

mweinelt commented Oct 1, 2020

I'll make the changes to home-assistant in a followup PR. Home assistant needs a version bump anyway as 0.115.x has been released.

I've taken care of the home-assistant update in #99217. You can regenerate the component-packages now and I'll rebase on top of that, or we do it the other way around. I don't mind.

@JamieMagee
Copy link
Member Author

I think I'll just wait until your PR goes in, and then I'll rebase on top of that. I'm in no rush to get this merged.

@mweinelt mweinelt self-assigned this Oct 2, 2020
@mweinelt
Copy link
Member

mweinelt commented Oct 3, 2020

Result of nixpkgs-review pr 98452 1

6 packages built:
  • python37Packages.adb-shell
  • python37Packages.androidtv
  • python37Packages.pure-python-adb
  • python38Packages.adb-shell
  • python38Packages.androidtv
  • python38Packages.pure-python-adb

mweinelt
mweinelt reviewed Oct 3, 2020
View reviewed changes
pkgs/development/python-modules/pure-python-adb/default.nix
# Disable tests as they require docker, docker-compose and a dedicated
# android emulator
doCheck = false;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, we're missing a pythonImportsCheck here.

Last gotcha.

mweinelt
mweinelt requested changes Oct 3, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit.

@mweinelt mweinelt merged commit 5bfedbf into NixOS:master Oct 3, 2020
@JamieMagee JamieMagee deleted the adb-shell branch October 3, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

@mweinelt mweinelt

Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JamieMagee @mweinelt