Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixops-aws
base: 76f65a212df1
Choose a base ref
...
head repository: NixOS/nixops-aws
compare: 34307d33fafa
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Sep 21, 2020

  1. volumes: treat non-aliased devices as equivalent to aliased ones 

    The AWS API provides us with some non-sensical device names that might
have nothing to do with reality. For some reason there is weird renaming
going on from the values that boto3 (the AWS API bindings) returns to us
to what we actually configure on the machine. Apparently nowadays some
volumes are not properly being mapped from AWS to NixOps. Amazon doesn't
appear to give much of a guarantee (or any) in terms of device names.
Accepting the "real" device name instead of the mapped device name gets
rid of issue #105. In an ideal world Amazon would be providing WWUIDs,
device paths or some other attribute that they can define with the block
device. Since that doesn't (seem to) exist we must live with this change
until someone comes up with a better solution.
    @andir
    andir committed Sep 21, 2020
    Copy the full SHA
    94265b4 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Merge pull request #114 from andir/treat-aliased-devices-the-same 

    volumes: treat non-aliased devices as equivalent to aliased ones
    @grahamc
    grahamc committed Sep 22, 2020
    Copy the full SHA
    34307d3 View commit details
    Browse the repository at this point in the history