Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox, firefox-bin: 80.0.1 -> 81.0, firefox-esr: 78.2.0esr -> 78.3.0esr [High security fixes] #98469

Merged
merged 3 commits into from Sep 23, 2020
Merged

firefox, firefox-bin: 80.0.1 -> 81.0, firefox-esr: 78.2.0esr -> 78.3.0esr [High security fixes] #98469

merged 3 commits into from Sep 23, 2020

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Sep 22, 2020

Motivation for this change
  • High security fixes
  • Other changes and fixes.

https://www.mozilla.org/en-US/firefox/81.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-42/

https://www.mozilla.org/en-US/firefox/78.3.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-43/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Note

Firefox 81 requires MACH_USE_SYSTEM_PYTHON or virtualenv in HOME.

@ofborg ofborg bot requested review from edolstra and andir September 22, 2020 14:03
@mohe2015
Copy link
Contributor

Shouldn't this be merged ASAP if these are high security fixes?

@kevincox
Copy link
Contributor

Since @taku0 has permissions I was letting him merge in case there is anything that remains to be done.

@taku0
Copy link
Contributor Author

taku0 commented Sep 23, 2020

I don't have privilege to merge. I'm a nixpkgs-maintainers member but not nixpkgs-committers. I don't see a merge button on this page.

@kevincox kevincox merged commit c5e8e4c into NixOS:master Sep 23, 2020
@kevincox
Copy link
Contributor

My mistake! I'll need to check up on what the different groups mean.

@vcunat
Copy link
Member

vcunat commented Sep 23, 2020

The "Member" badge is unfortunately a bit confusing in this way. IIRC it was a known downside when creating the -maintainers team.

This was referenced Sep 24, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincox kevincox kevincox approved these changes

@ajs124 ajs124 ajs124 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@taku0 @mohe2015 @kevincox @vcunat @ajs124 @doronbehar