Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why3: 1.3.1 → 1.3.3 #98441

Merged
merged 1 commit into from Sep 23, 2020
Merged

why3: 1.3.1 → 1.3.3 #98441

merged 1 commit into from Sep 23, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 22, 2020

Motivation for this change

Bug fixes: 1.3.2 1.3.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from thoughtpolice September 22, 2020 05:34
@doronbehar
Copy link
Contributor

Could you please not use unicode in commit messages? It makes it hard to grep this. A mere package update as this won't interest anybody in the future, probably; but for the sake of consistency.

@vbgl
Copy link
Contributor Author

vbgl commented Sep 23, 2020

By design of UTF-8, grep is compatible with “unicode” texts and patterns. For instance you can write the following shell command and get interesting results:

git log | grep 'why3:.*\(→\|->\)'

I’ve just amended the commit message.

@vbgl
Copy link
Contributor Author

vbgl commented Sep 23, 2020

@GrahamcOfBorg build framac

@doronbehar
Copy link
Contributor

I’ve just amended the commit message.

The Darwin build hangs for too long, and x86_64 build succeeds.

@doronbehar doronbehar merged commit 0307d0e into NixOS:master Sep 23, 2020
@vbgl vbgl deleted the why3-1.3.3 branch September 23, 2020 07:39
@vbgl
Copy link
Contributor Author

vbgl commented Sep 23, 2020

Merged into 20.09 as 9b0e8d7

@vbgl vbgl mentioned this pull request Apr 7, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @doronbehar