Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.py-sonic: init at 0.7.7 #99219

Merged
merged 2 commits into from Oct 2, 2020
Merged

python3Packages.py-sonic: init at 0.7.7 #99219

merged 2 commits into from Oct 2, 2020

Conversation

wenngle
Copy link
Member

@wenngle wenngle commented Oct 1, 2020 •
edited

Motivation for this change

python module for the subsonic API

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wenngle wenngle changed the title Pysonic python3Packages.pysonic: init at 0.7.7 Oct 1, 2020
mweinelt
mweinelt requested changes Oct 1, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I added some remarks.

pkgs/development/python-modules/pysonic/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pysonic/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pysonic/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pysonic/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
wenngle
wenngle commented Oct 1, 2020
View reviewed changes
Copy link
Member Author

@wenngle wenngle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed all proposed changes. Thanks for the feedback

pkgs/development/python-modules/pysonic/default.nix Outdated Show resolved Hide resolved
@mweinelt
Copy link
Member

mweinelt commented Oct 1, 2020

When you're done please rebase and squash your changes.

@mweinelt
Copy link
Member

mweinelt commented Oct 2, 2020 •
edited

The commit message does not fit https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md.

Please move the maintainer-list change into it's own commit. Sorry, I forgot mention that.

wenngle
wenngle commented Oct 2, 2020
View reviewed changes
Copy link
Member Author

@wenngle wenngle left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer list change is now its own commit

@adisbladis adisbladis removed their request for review October 2, 2020 12:18
@mweinelt
Copy link
Member

mweinelt commented Oct 2, 2020 •
edited

The other commit still starts with

parent 6cf69de

while it should be

python3Packages.py-sonic: init at 0.7.7

And please also remove the stacked commit messages from that commit.

@wenngle
Copy link
Member Author

wenngle commented Oct 2, 2020

I've cleaned up the commit messages

@mweinelt mweinelt changed the title python3Packages.pysonic: init at 0.7.7 python3Packages.py-sonic: init at 0.7.7 Oct 2, 2020
@mweinelt
Copy link
Member

mweinelt commented Oct 2, 2020

Result of nixpkgs-review pr 99219 1

2 packages built:
  • python37Packages.py-sonic
  • python38Packages.py-sonic

@mweinelt mweinelt merged commit ceba0ce into NixOS:master Oct 2, 2020
@wenngle wenngle deleted the pysonic branch October 2, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@stigtsp stigtsp Awaiting requested review from stigtsp

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wenngle @mweinelt @Janik-Haag