Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lilypond: add patch to restrict embedded-{ps,svg} when -dsafe is used #99220

Merged
merged 1 commit into from Oct 3, 2020
Merged

lilypond: add patch to restrict embedded-{ps,svg} when -dsafe is used #99220

merged 1 commit into from Oct 3, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 1, 2020

Motivation for this change

Fixes: CVE-2020-17353
Closes: #96802

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt requested a review from yurrriq October 1, 2020 03:32
@yurrriq
Copy link
Member

yurrriq commented Oct 3, 2020

Thanks! Works as expected on a few projects locally, but I don't do any PS or SVG embedding. Given that the patch is so simple, and upstream is satisfied, though, I'd say this should be merged.

@mweinelt mweinelt merged commit 22dd091 into NixOS:master Oct 3, 2020
@mweinelt mweinelt deleted the lilypond branch October 3, 2020 16:21
@mweinelt mweinelt mentioned this pull request Oct 3, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurrriq yurrriq yurrriq approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 92: lilypond-2.20.0: 1 advisory [9.8]
2 participants
@mweinelt @yurrriq