libhandy update is backwards incompatible, see #98316

@Atemu I see on your issue that you got this working, could you bump the rev?

Giara has a tagged release now.

/marvin opt-in
/status needs_reviewer

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

Needs bumping before review, as it stands from my test it doesn't work

Forgive me, I keep forgetting this app doesn't show commit updates

Thanks..?

Huh odd, what made Marvin think @bqv agreed to do a review? @timokau

I'm pretty sure they are going to do that but it's not been said explicitly.

I think such a response is surprising as a potential reviewer who doesn't have time right now could just set the awaiting_reviewer manually.

@GrahamcOfBorg eval

Edit: unsure why borg hates this

Huh odd, what made Marvin think @bqv agreed to do a review? @timokau

Basically any comment from somebody that is not the PR-author is treated as a potential "review". Its a heuristic of course, with the intent to keep the "needs reviewer" queue as uncluttered as possible. If its inaccurate, you can always set it back or wait until it times out. But I think its usually accurate.

I think such a response is surprising as a potential reviewer who doesn't have time right now could just set the awaiting_reviewer manually.

I think relying on that would mean much more manual status changes, which probably just won't happen. Then the "needs reviewer" queue has a bunch of PRs that actually are already in review, which can be demotivating when going through the queue manually and which can waste reviewer capacity when marvin assigns reviewers.

The name of the label maybe isn't ideal. "awaiting_reviwer" means that the PR is currently in review, and marvin is not sure weather or not the reviewer has actually requested any changes. The only difference to "awaiting_changes" is that marvin will eventually time out "awaiting_reviwer" back to "needs_reviewer".

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

/status needs_changes

/status awaiting_changes

Any warnings in the terminal about the images?

Nope :/

I would hazard a guess that cairo might be missing in some form

This seems to work for me:

{ lib
, fetchFromGitLab
, meson
, gobject-introspection
, pkg-config
, ninja
, python3
, wrapGAppsHook
, gtk3
, gdk-pixbuf
, webkitgtk
, gtksourceview4
, libhandy
, glib-networking
}:

python3.pkgs.buildPythonApplication rec {
  pname = "giara";
  version = "0.2";

  format = "other";

  src = fetchFromGitLab {
    domain = "gitlab.gnome.org";
    owner = "World";
    repo = pname;
    rev = version;
    sha256 = "1ca7ldf0rd19aixbdjvamqs55f3iig9wahgczik24r6knxj1bxl4";
  };

  nativeBuildInputs = [
    meson
    gobject-introspection
    pkg-config
    ninja
    wrapGAppsHook
  ];

  buildInputs = [
    gtk3
    gdk-pixbuf
    webkitgtk
    gtksourceview4
    libhandy
    glib-networking
  ];

  pythonPath = with python3.pkgs; [
    pygobject3
    pycairo
    dateutil
    praw
    pillow
    mistune
    beautifulsoup4
  ];

  # Fix setup-hooks https://github.com/NixOS/nixpkgs/issues/56943
  strictDeps = false;

  meta = with lib; {
    description = "A Reddit app, built with Python, GTK and Handy. Created with mobile Linux in mind.";
    maintainers = with maintainers; [ atemu ];
    homepage = "https://gitlab.gnome.org/World/giara";
    license = licenses.gpl3Plus;
    platforms = platforms.linux;
  };
}

Had to sniff the Location header reddit redirected to, since Firefox does not like the custom protocol: https://web.archive.org/web/20200613135416/https://www.fxsitecompat.dev/en-CA/docs/2020/navigation-to-unknown-protocol-will-be-blocked/, and then run giara 'URL' to be able to log in, thought.

@jtojnar That installed giara, but it fails to launch:

Traceback (most recent call last):
  File "/nix/store/q9rx4800vvyl7rxls8sdnl9fvw809456-giara-0.2/bin/..giara-wrapped-wrapped", line 70, in <module>
    gi.require_version('Handy', '1')
  File "/nix/store/hi5fmb38iy9ykp33g4gqh1h1kc520q8j-python3.8-pygobject-3.36.1/lib/python3.8/site-packages/gi/__init__.py", line 132, in require_version
    raise ValueError('Namespace %s not available for ver

@srid If you are rebasing onto unstable, you need to include the libhandy bump (in staging).

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@jtojnar would you perhaps just push your changes so this can be merged, since that works?

@jtojnar ?

Cannot do that at the moment, but feel free to open a new PR against staging-next.

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@timokau libhandy is in master now so it needs a rebase and changing the expression to #99188 (comment) to fix the bugs reported above.

I don't intend on packaging this anymore, feel free to pick this up.