Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitwig-studio3: jack dependency fixed #99193

Merged
merged 1 commit into from Nov 23, 2020
Merged

bitwig-studio3: jack dependency fixed #99193

merged 1 commit into from Nov 23, 2020

Conversation

bfortz
Copy link
Contributor

@bfortz bfortz commented Sep 30, 2020

Motivation for this change

Runtime dependency missing was causing failure of the jack audio engine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ X ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ X ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [ X ] Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from michalrus September 30, 2020 20:02
@prusnak prusnak mentioned this pull request Nov 17, 2020
Closed
10 tasks
@prusnak prusnak merged commit deb0943 into NixOS:master Nov 23, 2020
@bfortz bfortz deleted the bitwig branch February 17, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@mrVanDalo mrVanDalo mrVanDalo approved these changes

@michalrus michalrus Awaiting requested review from michalrus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bfortz @prusnak @mrVanDalo